Eyevinn / hls-m3u8 / 30294630790

92%

Build Type

push

github

Committed by tobbee

Commit Message

fix: remove expired partial segments when a full segment is appended

removeExpiredPartials was only called from AppendPartialSegment, so the
retention rule was only applied when a new partial segment arrived. A
producer that stops adding partial segments, for example at the end of a
stream or when switching away from low latency, kept them forever, and
IsSegmentReady kept reporting them as available long after they had left
the playlist. Encode filtered them out of the output, so this was stale
in-memory state rather than a bad playlist.

Call it from AppendSegment as well, since a new full segment also moves
the end of the playlist forward. Remove is not affected, as it moves the
head and leaves the end of the playlist where it was, and Slide appends.

Also state the retention rule once, as a named constant referring to the
three target durations of the specification, and filter in place instead
of rebuilding the slice on every call. The previous comment claimed to
keep all partial segments when there are fewer than 3 full segments, but
the value tested is a sequence number, not a count. It only guards
against underflow, which the new code says explicitly.

Coverage Stats

13 of 13 new or added lines in 1 file covered. (100.0%)

37 existing lines in 1 file now uncovered.

2246 of 2429 relevant lines covered (92.47%)

1.08 hits per line