stacklok / toolhive-studio / 30289556341

72%

push

github

fix: make thv startup resilient to SQLite failures (#2526)

* fix: make thv startup resilient to SQLite failures

Guard readSetting('isTelemetryEnabled') during startToolhive so a
better-sqlite3 dlopen failure cannot prevent thv from spawning. Also
await the Sentry.withScope body and clear the socket path when startup
throws before the process is running.

Fixes the app-bricking half of #2509 on Ubuntu 22.04 when SQLite is
unavailable.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: format startup errors for Sentry instead of JSON.stringify

Error objects serialize to {} with JSON.stringify, losing the message
that explains why thv failed to start.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: respect telemetryStore opt-out when SQLite read fails

On DB failure, read isTelemetryEnabled from electron-store instead of
failing open. Also gate fatal Sentry/tray updates in the startup catch
on !isToolhiveRunning() so post-spawn throws do not mark thv as down.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

5606 of 8299 branches covered (67.55%)

60 of 62 new or added lines in 1 file covered. (96.77%)

8313 of 11483 relevant lines covered (72.39%)

148.75 hits per line