hathitrust / holdings-backend / 30288106094

96%

Build Type

push

github

Committed by web-flow

Commit Message

ETT-253 Holdings: handle change in format; automate/improve old holdi… (#454)

* ETT-253 Holdings: handle change in format; automate/improve old holdings deletion
- `PreLoadBackup::delete_marked!` follows best practices for large MariaDB deletes.
- Update `holdings` table schema with `SHOW CREATE TABLE` from production.
- Convert `phctl scrub ... --type-check={check/delete/append}` parameter.
- Add `Scrub::Preflight` class and require `Scrub::ScrubRunner` to check all member-submitted files before kicking off backup/load/delete operations.
- `Loader::FileLoader` recovers gracefully when given an empty file with the expectation of a header line.
- TIDY: suppress remaining logging/`puts` noise when running `rspec`.

Coverage Stats

118 of 119 new or added lines in 10 files covered. (99.16%)

9 existing lines in 3 files now uncovered.

7122 of 7404 relevant lines covered (96.19%)

128.91 hits per line