ReactiveX / RxPY / 30285717303

93%

push

github

refactor(combine-latest): simplify logic by removing redundant loops … (#736)

* refactor(combine-latest): simplify logic by removing redundant loops and improving docs

- Removed two unnecessary nested loops, reducing complexity and improving performance
- Replaced mutable list flags with `nonlocal` variables for cleaner state handling
- Added fallback `threading.RLock()` when `parent.lock` is not present
- Improved type hints using generics (`TypeVar`, `Tuple[T, ...]`)
- Added input validation to raise `ValueError` when no sources are provided
- Expanded and standardized docstring (PEP 257 + NumPy style)

* fix(combine-latest): add catch-all overload and cover empty-source error

The combine_latest() overloads only covered 2-4 sources, so calls with 1 or
5+ sources matched no overload and inferred as Unknown. Add a catch-all
overload degrading to tuple[Any, ...], matching zip()'s behaviour. This also
makes the cast in operators/_combinelatest.py unnecessary.

Document the ValueError raised for zero sources on the public API, and add
tests for the zero-source and single-source cases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Dag Brattli <dag@brattli.net>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

13 of 13 new or added lines in 3 files covered. (100.0%)

25714 of 27466 relevant lines covered (93.62%)

0.94 hits per line