AAEmu / AAEmu / 30279799425

5%

push

github

fix(items): delete sold item rows so they do not dupe on relogin (#1489)

Selling an item moves it into the BuyBack container, which is a
non-persisted SlotType.None container. The item was removed from the
Bag in memory but its existing persisted row in the items table was
never updated or deleted, so on relogin the stale row reloaded and the
item reappeared in the inventory while the player kept the sale money.

Queue the sold item row for deletion via a new
ItemManager.MarkItemForDbDeletion helper (adds to the removed-items
list without freeing the runtime id or unlisting the live item, so the
BuyBack entry keeps working). Save() deletes queued rows before
re-inserting current items, so buying the item back (which moves it
into a persisted container again) still persists correctly.

Fixes #1189

0 of 6 new or added lines in 2 files covered. (0.0%)

3296 of 69504 relevant lines covered (4.74%)

0.05 hits per line