AAEmu / AAEmu / 30278269431

5%

Build Type

push

github

Committed by web-flow

Commit Message

fix(game): keep gems on failed socket and guard full-item out-of-range (#1468)

* fix(game): ItemSocketing IndexOutOfRange when socketing a full item

equipItem.GemIds[gemCount] was written without checking gemCount against
GemIds.Length, throwing IndexOutOfRangeException when socketing an item whose
gem sockets are already full. Adds an early free-socket check.

(Original PR also removed the failure-branch gem wipe, but per @ZeromusXYZ that
clearing is correct pre-guild-gem 1.2 behaviour, so it is kept unchanged.)

* fix(socketing): keep fail wipe behavior

* fix(game): keep existing gems on failed socket attempt

On this client version (r208022) a failed LunaGem socket does not remove
already socketed gems; only the out-of-range guard on a full item is kept.

* fix(socketing): re-implement retail r208022 gem-wipe on failed socket

Per maintainer: in early versions (r208022) a failed socket removes ALL
socketed gems. Restore that behavior; keep the free-socket OOB guard.

Coverage Stats

0 of 3 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

3296 of 69494 relevant lines covered (4.74%)

0.05 hits per line