source-academy / frontend / 30270061935

43%

push

github

Make Conductor-based assessment workspaces (Run + testcase grading) work for non-js-slang languages (#4057)

* Concatenate prepend into entrypoint under Conductor instead of evaluating it separately

Conductor runs each evalCodeSaga call in a fresh, isolated worker that is
terminated after use, so bindings from a silently-evaluated prepend never
carry over into the entrypoint's own worker. This made quest/mission/path
prepend definitions (e.g. pair, pizza) appear unrecognised when running
under Conductor. Concatenate prepend + entrypoint into a single file for a
single Conductor run instead, mirroring the existing Variant.TYPED handling.

* Skip js-slang debugger-statement pre-parse when running under Conductor

insertDebuggerStatements() used context.chapter to decide whether to
run js-slang's parser as a pre-check. Assessment questions carry a
legacy chapter field (backend only accepts Source chapters 1-4, with
no non-Source option), so a Conductor/Python question's chapter still
reads as a Source chapter and js-slang's parser was being run against
non-JS source before Conductor ever got to evaluate it, producing
spurious syntax errors like "Missing semicolon at the end of
statement". debugger; is JS/Source-specific anyway, so skip this
entirely whenever Conductor is enabled.

* Make testcase grading Conductor-aware by running prepend+code+postpend+testcase as one file

evalTestCode.ts still hardcodes js-slang's runInContext directly, and
the legacy prepend/postpend/testcase flow relies on a single mutable
js-slang Context shared across four separate evalCodeSaga calls -
neither works under Conductor, since each call gets a fresh, isolated
worker that's torn down afterwards.

When Conductor is enabled, skip the elevated-context/blockExtraMethods
privilege dance (a js-slang-specific concept with no Conductor
equivalent) and instead concatenate prepend, the student's code,
postpend, and the testcase expression into a single file for one
Conductor run.... (continued)

2818 of 7611 branches covered (37.03%)

Branch coverage included in aggregate %.

57 of 68 new or added lines in 8 files covered. (83.82%)

6567 of 14305 relevant lines covered (45.91%)

28.61 hits per line