kobotoolbox / kpi / 30269159095

push

github

fix(submissions): use correct Mongo indexes on `root_uuid`/`_uuid` fields INFRA-551 (#7307)

### 👷 Description for instance maintainers

This is the application-side counterpart to kobotoolbox/kobo-docker#381,
which reworks the MongoDB indexes on the `instances` collection (drops
indexes that only backed dead code, adds indexes matching how the app
actually queries `meta/rootUuid`/`_uuid`). Both PRs should land together
on an instance.

Two changes here:

- `kobo/apps/long_running_migrations/jobs/0028_sync_mongo_root_uuid.py`:
simplifies the "still missing root_uuid" query to a plain
`meta/rootUuid: {$exists: False}` (was also matching `None`/`''`, which
the backfill never produces), matching the shape of the new
`id_rootUuid_idx` index from kobo-docker#381. Also tightens
`_check_lrm_0027_is_completed` to require LRM 0027's status to be
strictly `completed` before 0028 runs, instead of accepting `completed`
or `failed`.
- `kpi/views/v2/data.py` (`_get_submission_by_id_or_root_uuid`): the
legacy UUID-lookup fallback now queries `_uuid` instead of
`meta/instanceID`, matching the `{_userform_id, _uuid}` index added in
kobotoolbox/kobo-docker#381 rather than relying on an index we're
retiring.

### 💭 Notes

Related to kobotoolbox/kobo-docker#381.

9309 of 12656 branches covered (73.55%)

30343 of 37235 relevant lines covered (81.49%)

5.51 hits per line