openego / eDisGo / 30261459569

83%

dev: 84%

Build Type

Pull #629

github

Committed by web-flow

Commit Message

fix: reduce dumb/reduced/flexibility_bands to the active timeindex before building (#727)

Part of #703 follow-up (ADR 0002). dumb/reduced previously wrote each
charging event's deterministic interval unconditionally into a
full-SimBEV-length series, relying solely on a later crop step to trim
to the active timeindex. Now clips the placement slice itself to
whatever overlaps the active timeindex, at unchanged power - correctly
handling a gap inside a single event's interval by writing each
in-window sub-slice independently.

get_flexibility_bands had the same underlying issue: its output values
were already correct after the existing final .loc[timeindex] clip, but
construction itself built over EVERY charging process and SimBEV's
entire simulated range regardless of how much shorter the active
timeindex was - real "build full, then crop" waste, just hidden behind
correct output. Now filters to events overlapping the active timeindex
first and sizes the construction array to only what those events plus
the active window require, while avoiding a pre-existing edge case
(an event's true end landing exactly on the array's last row gets
silently excluded) that the tighter sizing would otherwise trigger far
more often.

See docs/adr/0002-charging-time-series-reduced-to-active-timeindex-before-building.md.

Pull Request Pull Request #629: Edisgo run edisgo

Coverage Stats

859 of 1137 new or added lines in 29 files covered. (75.55%)

2 existing lines in 2 files now uncovered.

9565 of 11482 relevant lines covered (83.3%)

0.83 hits per line