kobotoolbox / kpi / 30267991509

push

github

fix(tags): return each tag once from `/api/v2/tags/` DEV-1576 (#7315)

### 📣 Summary
`TagViewSet.get_queryset()` filters across the `taggit_taggeditem` join
table, so a tag attached to N accessible assets was emitted N times,
`.distinct()` collapses it back to one row per tag.

### 📖 Description
`TagViewSet.get_queryset()` filters `Tag` on
`taggit_taggeditem_items__*` to restrict tags to assets the user may
view. Because that filter spans a multi-valued relationship, the
underlying SQL joins `taggit_tag` onto `taggit_taggeditem` and returns
one row per tag/asset pairing so a tag applied to two accessible assets
came back twice, with an identica `name` and `url`.

9523 of 12839 branches covered (74.17%)

30827 of 37660 relevant lines covered (81.86%)

5.51 hits per line