zalando / logbook / 5764

97%

master: 100%

push

github

Fix CachingHttpResponse dropping attributes on withoutBody() (#2328)

* Fix CachingHttpResponse dropping attributes on withoutBody()

When BodyOnlyIfStatusAtLeastStrategy called response.withoutBody() on
a CachingHttpResponse, the resulting response lost all HttpAttributes
extracted by AttributeExtractor, because CachingHttpResponse inherited
ForwardingHttpResponse.withoutBody() which delegates to the underlying
response and discards the cached attributes.

Override withoutBody() and withBody() in CachingHttpResponse to return
a new CachingHttpResponse preserving the original HttpAttributes.

Fixes #2115

* Remove redundant inline comments per review feedback

874 of 922 branches covered (94.79%)

2 of 2 new or added lines in 1 file covered. (100.0%)

4009 of 4150 relevant lines covered (96.6%)

0.97 hits per line