GrottoCenter / grottocenter-api / 30208615319

87%

develop: 91%

Build Type

Pull #1741

github

Committed by ClemRz

Commit Message

fix(csvImport): address review suggestions

- generateAndUploadReports: upload each report independently with its
  own try/catch so a failure on one does not discard URLs already
  uploaded successfully
- FileService: remove getSharedKeyCredential (dead code since SAS
  generation was dropped from uploadReport)
- Fix JSDoc @returns typo: success -> successes
- CSVImportQueueService.property.test.js: use arrow function on
  describe and chain .timeout() on it() instead of function keyword
  on describe block, eliminating the func-names lint warning

Pull Request Pull Request #1741: fix(csvImport): fix batch status=failed on successful import

Coverage Stats

5103 of 6139 branches covered (83.12%)

Branch coverage included in aggregate %.

3 of 12 new or added lines in 1 file covered. (25.0%)

2 existing lines in 1 file now uncovered.

9445 of 10530 relevant lines covered (89.7%)

134.05 hits per line