GrottoCenter / grottocenter-api / 30207358373

87%

develop: 91%

Build Type

Pull #1741

github

Committed by ClemRz

Commit Message

fix(csvImport): fix two root causes found in production logs

Bug 1 - processOneChunk crashes on coordinates snapshot invalidation:
sails.services.coordinatessnapshotservice is undefined in the pg-boss
worker context (outside the Sails request lifecycle). Replace with a
direct require() call, consistent with all other service references
in processOneChunk.

Bug 2 - aggregation fails with Invalid sharedKeyCredential error:
generateBlobSASQueryParameters fails because the StorageSharedKeyCredential
instance fails the Azure SDK instanceof check when the module is
required across different require-cache contexts. The documents container
already allows anonymous read access so SAS tokens are unnecessary.
Drop SAS generation entirely from uploadReport and return the plain
blob URL directly. Remove now-unused BlobSASPermissions and
generateBlobSASQueryParameters imports.

Pull Request Pull Request #1741: fix(csvImport): fix batch status=failed on successful import

Coverage Stats

5104 of 6145 branches covered (83.06%)

Branch coverage included in aggregate %.

3 of 5 new or added lines in 1 file covered. (60.0%)

43 existing lines in 2 files now uncovered.

9447 of 10535 relevant lines covered (89.67%)

132.77 hits per line