dal-go / dalgo / 30207238497

100%

push

github

fix(mocks): regenerate session and transaction mocks so recorders match (#107)

MockReadSession, MockReadwriteSession, MockReadTransaction and
MockReadwriteTransaction each implemented ExecuteQueryToRecordsReader and
ExecuteQueryToRecordsetReader while their recorders still exposed the
pre-rename names GetRecordsReader and GetRecordsetReader. The recorder bodies
recorded the new method names, so the wrappers were merely misnamed and our own
tests kept passing - but a consumer writing EXPECT().ExecuteQueryToRecordsReader
against the real interface got a compile error, with no way to set a query
expectation at all. dal-go/dalgo-demo hit exactly this while migrating to
v0.64.2.

This is the L1 pattern in our own repo: the fake drifted from the interface it
stands in for, our tests were written against the drifted fake, and every signal
stayed green. Nothing compares a generated mock against the interface it is
generated from, so a hand-edit or partial regeneration is invisible.

Regenerated both files with mockgen v0.6.0, the version in go.mod, and renamed
the 27 EXPECT() call sites in our own tests. The rename is behaviour-preserving:
the old recorder already recorded "ExecuteQueryToRecordsReader", so the same
expectation is set on the same method. Scoped strictly to EXPECT() call sites -
GetRecordsReader is also a real method on dal.Query with a different signature,
and a blanket rename would have corrupted those.

Verified: build, vet and all 19 packages green. Proven load-bearing against
dalgo-demo via a local replace - it now builds, vets and tests clean, having
failed to compile before.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

156 of 156 new or added lines in 2 files covered. (100.0%)

8848 of 8851 relevant lines covered (99.97%)

1.15 hits per line