lunarmodules / copas / 30206523120

86%

Build Type

push

github

Committed by Tieske

Commit Message

fix(semaphore): stop leaking resources to canceled queue waiters

Same root cause as the copas.lock deadlock (#199): semaphore:give()
deducted a queued waiter's requested resources from the pool and then
called copas.wakeup() without checking whether it actually resumed
the coroutine. If that waiter had been canceled externally (eg. via
copas.removethread()/future:cancel()) while queued, the resources
were permanently subtracted from the pool even though the canceled
coroutine never runs to consume or return them - silently shrinking
the semaphore's effective capacity forever, and starving any real
waiter still queued behind it.

give() now only deducts the resources once copas.wakeup() confirms
the waiter actually resumed; a stale/canceled entry is dropped without
touching the count, and the loop continues to the next waiter in line.

Coverage Stats

18 of 18 new or added lines in 2 files covered. (100.0%)

127 existing lines in 5 files now uncovered.

1429 of 1679 relevant lines covered (85.11%)

67776.83 hits per line