kivy / kivy / 30202678850

60%

Build Type

push

github

Committed by web-flow

Commit Message

kivy.mobile: pull the Android Activity from the bootstrap instead of a hardcoded PythonActivity (#9352)

* kivy.mobile: pull the Android Activity from the bootstrap

The Android backend reflected a hardcoded org.kivy.android.PythonActivity.  That
is a python-for-android implementation detail, and it silently breaks any build
whose activity is named something else, including p4a's own
--activity-class-name.

Kivy now names no activity class.  It imports a top-level `_kivy_bootstrap`
module supplied by whoever built the APK and pulls the Activity from it on every
access, so nothing goes stale when Android recreates the Activity on rotation,
configuration change or process death.  A missing module while an Android
runtime is present raises ActivityProviderMissing rather than degrading to
plausible-looking defaults, since it can only mean the app was built by
something that does not support Kivy 3; off-device the getters keep returning
their documented defaults.

Kivy pulls rather than the bootstrap registering a provider at startup.  p4a
runs the app's main.py as the process entry point, so it has no Python of its
own to register from, and registering would mean importing Kivy before the app
could set its KIVY_* environment and config.

Two optional members keep bootstraps that differ from p4a working: get_context()
for processes that never have an Activity, and remove_presplash(), because
dismissing a splash belongs to the bootstrap -- p4a removes an overlaid View,
while a bootstrap using the Android 12 system splash has no such method to
offer.  base.py's remove_android_splash now goes through that hook.

app.py and clipboard_android.py move off PythonActivity onto the backend, which
gains run_on_ui_thread(), get_files_dir() and get_cache_dir() so neither needs
jnius boilerplate or an Activity of its own; the clipboard also stops stashing
state on the Activity class.  Afterwards no PythonActivity or mActivity
reference remains outside the test harness.... (continued)

Coverage Stats

3289 of 6511 branches covered (50.51%)

159 of 193 new or added lines in 4 files covered. (82.38%)

23 existing lines in 9 files now uncovered.

29689 of 49186 relevant lines covered (60.36%)

1.19 hits per line