valkyrjaio / valkyrja-starter-app-ts / 30187021981

100%

push

github

[Tests] Add HTTP and CLI entry-point smoke tests (#73)

# Description

Adds end-to-end smoke tests for the application's two entry points so a
regression that breaks the app's actual boot — entry wiring, provider
bootstrap,
routing/command discovery — is caught, even when the class-level unit
tests still
pass. These live in the normal Vitest suite (not a sindri generated-code
build)
so they run on every PR: the framework discovers routes/commands at
runtime in
debug mode, so the entries function against the committed (empty) data
stubs.

- **`CliEntry`** runs the real CLI entry (`bin/cli.ts` runs `App.run(new
Config())`)
in process and asserts the `list` command boots and lists the
application's own
  `test` command, with no thrown/uncaught error.
- **`HttpEntry`** boots `App/Http/App` with the application's real
`ComponentProvider`, dispatches a `GET /` request through the request
handler,
  and asserts a 2xx response rendering the welcome view.

Both entries are exercised **in process** rather than as subprocesses:
the
framework is published as raw TypeScript resolved from `node_modules`,
which
Node's type stripping refuses to execute
(`ERR_UNSUPPORTED_NODE_MODULES_TYPE_STRIPPING`),
so `node bin/cli.ts` cannot run against a normal install — Vitest's
transform is
what makes the framework source runnable. Booting the real entry classes
in
process gives the same regression coverage without depending on that.

The HTTP smoke uses a debug-mode config (as the CLI config already is)
so routes
are discovered at runtime against the empty committed stubs; the app's
committed
`Http/Config` runs non-debug and would require generated routing data.

Requires the HTTP serving provider stack + request-dispatch fix added in
`@valkyrjaio/valkyrja` **26.3.0** (valkyrja-ts#82); this PR bumps the
dependency to
`^26.3.0`. Verified locally: both smoke tests pass; tsc, eslint, and
prettier are
clean.

## Related

- Framework support this depends on (adds the HTTP serving p... (continued)

8 of 8 branches covered (100.0%)

Branch coverage included in aggregate %.

72 of 72 relevant lines covered (100.0%)

2.11 hits per line