umputun / agterm / 30185853248
98%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 76
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 97.837%. Remained the same
30185853248

push

github

web-flow 
fix: address round-6 review findings on the Dock menu (#295)

* fix: address round-6 review findings on the Dock menu

Plain session nav (⌥⌘↑/↓, first/last) revealed the tagged pane even when the step
resolved to the session already selected, which clears splitFocused and drops the
user onto the primary pane on a keystroke that moved nothing. The four actions now
share navigatePlain, which reveals only when the selection actually changed.
Attention nav keeps its live-indicator fallback, which is what makes ⌃⌥↑/↓ still
reveal for a sole already-selected blocked session.

focusSplitPane gained the renamePending and palette guards focusActiveSession
already re-checks. The .left/nil reveal routes through it, so a row click followed
within its ~360ms retry window by ⌘R or a palette open could pull first responder
off the rename field.

Also cover closing a dashboard from a menu built while it was open, restore the
"Nothing to report" Coveralls symptom and the cache key in ci.md, record that the
build job compiles the app twice by design, fix the deleted
revealActiveBlockedPane() signature and the reveal-caller lists in sidebar.md,
correct the menu-actions.md claim that an empty filtered list preserves ordinary
focus, and refresh the stale uiActionsEnabled comment.

Related to #284

* fix(review-loop): iteration 1 addressed 1 finding

- [major] [agterm/AppActions+Focus.swift:162] scope the new rename/palette guards
  to the session's own window. Both flags are app-global while focusSplitPane is
  deliberately cross-window, so a palette open in the frontmost window skipped the
  responder move for a session.focus aimed at a background one, leaving that
  window's splitFocused and its real first responder disagreeing.

* fix(review-loop): final cleanup pass — addressed 3 findings

- [minor] [.claude/rules/menu-actions.md:298] the nav bullet still said every GUI
  action calls focusActiveSession() after the move, contradicting the paragraph
  added 12 lines be... (continued)

5970 of 6102 relevant lines covered (97.84%)

4927222.51 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30185853248.1 76
97.84
 GitHub Action Run
Source Files on build 30185853248