dangernoodle-io / breadboard / 30184238316

97%

push

github

fix: degrade doc-only schema-compose failures instead of aborting route init (#1095)

- bb_ota_validator_init(): a partitions-schema compose failure no longer
  aborts before GET /api/update/partitions and POST /api/update/recover are
  registered; it now logs a warning and leaves that route undocumented
  (schema stays NULL, already gated by bb_openapi_emit.c).
- bb_wifi_routes_init(): same degrade for the scan-schema compose failure
  (GET /api/wifi and POST /api/wifi/scan otherwise never registered). The
  info-schema check stays fatal-abort on purpose: it feeds a static buffer
  bound directly into bb_openapi_register_schema(), which is not NULL-safe
  the way the two route-response sites are -- converting it needs a
  NULL-then-patch rework, left for a follow-up.
- bb_wifi_routes_init(): reordered so GET /api/wifi, POST /api/wifi/scan,
  and (with CONFIG_BB_WIFI_RECONFIGURE) PATCH /api/wifi all register before
  the fatal-abort info-schema compose runs, mirroring
  bb_ota_validator_init()'s mark-valid-before-partitions-compose shape --
  an info-schema compose failure can no longer take the whole wifi HTTP
  surface down with it, only the OpenAPI document's WifiInfo schema.
- components/bb_wifi_http/CMakeLists.txt: extend the existing bb_log
  PRIV_REQUIRES justification comment to also cover
  bb_wifi_http_routes.c's new warning log.
- both degrade branches are annotated as an untested coverage gap: neither
  file is built by any native host test env.

7784 of 8389 branches covered (92.79%)

Branch coverage included in aggregate %.

13235 of 13392 relevant lines covered (98.83%)

2617.77 hits per line