dangernoodle-io / breadboard / 30182622314

97%

push

github

fix: flag CMakeLists-less orphan directories under components/ (B1-1227) (#1091)

- add discovery.find_orphan_component_dirs: distinguishes a genuine header-only orphan (no CMakeLists.txt anywhere in its subtree) from a legitimate grouping directory (no CMakeLists.txt of its own, but real leaf-component descendants)
- wire a new orphan-component-dir lint rule (error severity) naming the path of any such orphan; runs under make check, so a hit blocks a merge. gen_components_readme.py's group-member listing and both fence baseline families remain structurally blind to this shape -- fence/new_component.py's own module docstring still documents this as an open LATENT GAP, unchanged by this PR
- extract the shared symlink-guarded, sorted, dot-skipping child-iteration primitive (_resolve_dir + _iter_child_dirs) out of _leaf_component_dirs's walk and reuse it in find_orphan_component_dirs, rather than leaving a second hand-rolled copy (Consolidation convention)
- add a test pinning the actual production shape: a header-only orphan sitting beside a real leaf component under the same group parent (e.g. components/display/bb_display_ssd1306/ next to components/display/bb_display_ili9341/)
- correct component-readme's docstring, which claimed a bare/malformed directory is always caught 'no CMakeLists.txt anywhere under it' -- true only at depth 1; a nested orphan under a group directory was never actually covered by that rule
- make _has_header_signal's .h/.hpp extension check case-insensitive (extract _is_header_file, matching on p.suffix.lower() instead of a lowercase-only glob) so a directory whose only header uses an uppercase/mixed-case extension (e.g. FOO.H) is still flagged as an orphan; add a pinning test


Claude-Session: https://claude.ai/code/session_01GfDDq2y51mr8JYq7VW5qAh

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

7774 of 8379 branches covered (92.78%)

Branch coverage included in aggregate %.

13225 of 13382 relevant lines covered (98.83%)

2619.44 hits per line