dangernoodle-io / breadboard / 30181303685

97%

push

github

refactor: migrate remaining five bb_openapi producers to bb_data_http_describe() seam (B1-1220 PR3) (#1089)

Completes the B1-1220 migration off bb_openapi_register_topic_schema() onto the
bb_data_http_describe() seam (pilot: bb_log_event, PR #1084), copying its exact
shape for the five remaining in-tree producers verified by grepping the whole
tree for the legacy call:

- bb_ota_hooks: key/topic "ota.progress", component "OtaProgress"
- bb_health (bb_health_stack.c): key/topic "health.stack", component "HealthStack"
- bb_diag_http (bb_diag_http_routes.c): key/topic "diag.boot", component "DiagBoot"
- display/bb_display (bb_display_info.c): key/topic "health.display", component "DisplayInfo"
- bb_ota_check (bb_ota_check_common.c): key/topic "update.available", component "UpdateAvailable"

Each producer no longer links bb_openapi at all -- every touched CMakeLists.txt
drops it from REQUIRES/PRIV_REQUIRES (none had a public-header justification
either) and adds bb_data_http to PRIV_REQUIRES (internal .c use only); verified
via nm on the real smoke-esp32/floor-esp32 build objects (bb_ota_check_common.c.o,
bb_diag_http_routes.c.o, bb_display_info.c.o, bb_health_stack.c.o) plus a
temporary local manifest addition to also link-verify bb_ota_hooks.c.o (no
example currently wires it) -- all five reference bb_data_http_describe with
zero remaining bb_openapi undefined symbols.

Of the five touched components, only bb_diag_http already has a
components/bb_diag_http/README.md; this commit regenerates that one file
(its bb_ dependency table now lists bb_data_http instead of bb_openapi).
bb_health, bb_ota_check, bb_ota_hooks, and display/bb_display have never had
a README -- pre-existing repo-wide debt (bbtool lint's component-readme
check flags ~60 such directories, WARN-only) and out of scope here.

Every new bb_data_http_describe() call is doc-only bookkeeping (feeds
/api/openapi.json schema synthesis) and is non-fatal on failure -- it logs a
warning and falls ... (continued)

7774 of 8379 branches covered (92.78%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

13225 of 13382 relevant lines covered (98.83%)

2610.36 hits per line