dangernoodle-io / breadboard / 30180543029

97%

push

github

fix: don't abort five producers' init on a doc-only schema-compose failure (#1087)

- bb_ota_hooks_init(), bb_health_stack_monitor_init(), bb_diag_routes_init(),
  bb_display_register_info(), and bb_ota_check_init() all returned early (or,
  for the void bb_display_register_info(), bare `return;`) when their
  CONFIG_BB_OPENAPI_RUNTIME_META schema-compose call failed, aborting their
  own bring-up -- skipping route registration, the initial snapshot publish,
  timer creation, or the bb_data bind + s_registered flag entirely
- schema composition is documentation-only (feeds /api/openapi.json), so a
  compose failure must never take down real bring-up; now warn and fall
  through, matching the same degrade-and-continue posture as the other
  doc-only call sites already in these functions
- registration is now guarded on schema_rc == BB_OK in all five: on
  failure, each producer's own ensure_schema_patched() guarantees the
  schema buffer is left empty, and bb_openapi_register_schema() rejects
  only a NULL literal, not an empty one -- registering an empty literal
  would splice e.g. "OtaProgress": with no value into /api/openapi.json,
  corrupting the entire document, not just that producer's entry
- bb_display_register_info() stays void: its only caller (examples/smoke's
  entry_espidf.c) never checked a return value, so warn-and-continue is
  the minimal fix; a signature change would ripple across its public
  header and call site for no behavioral gain
- bb_ota_check_init() (bb_ota_check_common.c) has FOUR of these guarded
  compose call sites, not one -- update.available (the one that gates its
  own bb_openapi_register_topic_schema() call, same shape as the other four
  producers), plus GET /api/update/config and POST /api/update/config's
  request and response composes (three sites with no separate register call
  in this function -- their own ensure_*_schema_patched() helpers already
  gate the actual field-patch on success internally). All four... (continued)

7770 of 8375 branches covered (92.78%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 1 file covered. (100.0%)

13239 of 13396 relevant lines covered (98.83%)

2604.73 hits per line