valkyrjaio / valkyrja-starter-app-java / 30177716217

100%

push

github

[Application] Upgrade to valkyrja/sindri 26.2.0, fix framework auto-updates, add sindri-junit CI (#41)

# Description

Upgrades the starter app to **valkyrja / sindri 26.2.0**, adapts it to
that
release's breaking changes, and fixes the `update-dependencies` workflow
so the
framework dependency is actually picked up going forward.

**Why the workflow "found no updates":** the automated
`update-dependencies`
workflow only ran `useLatestVersions` in the five `.github/ci/*` tooling
subprojects. The application's own framework dependency lives in the
root
`build.gradle.kts` and `app/build.gradle.kts`, which were never scanned
— and
those builds didn't apply the `use-latest-versions` plugin — so the
framework
version the app ships was never bumped (it had drifted: root/`app` on
`26.1.1`,
CI dirs on `26.1.2`). This PR closes that gap.

**Breaking-change migration to compile on 26.2.0** (a plain version bump
would
not build):

- **Terminal middleware rename:** `app/http/Config` →
`ResponseSentMiddlewareContract`
  / `responseSentMiddleware` (was `Terminated…`); `app/cli/Config` →
`ProcessExitingMiddlewareContract` / `processExitingMiddleware` (was
`Exited…`).
- **CLI route handler signature:** `CliRouteProvider.testCommandHandler`
takes
`(ContainerContract, RouteContract)` instead of `(…, Map<String,
Object>)`,
matching 26.2.0's `BiFunction<ContainerContract, RouteContract,
OutputContract>`.

**Testing the generated data cache — two isolated CI environments.** The
junit CI
copies the committed empty `*.example.java` stubs and never runs sindri,
so it
verifies the app *as it compiles without generation*. sindri 26.2.0 now
emits a
fully-populated data cache (routes, container callbacks, paths) where
26.1.1
produced empty stubs — which the stub-based junit build can't see.
Rather than
mingle stubbed and generated results (fake passes / broken results),
this adds a
separate **`.github/ci/sindri-junit`** build that **runs sindri** to
generate the
real `App*Data` ... (continued)

6 of 6 branches covered (100.0%)

Branch coverage included in aggregate %.

245 of 245 relevant lines covered (100.0%)

5.89 hits per line