dangernoodle-io / breadboard / 30174570502

97%

push

github

fix: union topic-source seam into components/schemas (B1-1220 follow-up) (#1081)

- PR #1080 wired the injected topic-source seam into sse_schema_count()
  and build_sse_oneof_fragment() only (the SSE oneOf array); components/
  schemas itself never consulted it, so a producer migrating from
  bb_openapi_register_topic_schema() to bb_data_http_describe() would gain
  a $ref in oneOf with no matching schema body -- a dangling $ref, an
  invalid OpenAPI document
- add bb_openapi_schemas_union_count()/emit_external_schemas() to union
  the legacy registry with the describe table (legacy-first, matching the
  oneOf ordering), reusing the existing bb_openapi_topic_source_invoke()
  seam -- no new bb_data_http dependency
- single shared dedup rule (schema_already_emitted()/schema_dedup_mark()
  in bb_openapi_emit_shared.c), used by all four union consumers
  (sse_schema_count, build_sse_oneof_fragment, bb_openapi_schemas_union_
  count, emit_external_schemas): dedup by component_name, legacy-first-
  wins, across the WHOLE union -- legacy vs external AND external vs
  external, since bb_data_http_describe() dedups by key (not
  component_name), so two distinct topics can legitimately collide on one
  component_name; without external-vs-external dedup too, that collision
  emitted a duplicate components/schemas key and a duplicate oneOf $ref
  (violating its "exactly one match" semantics)
- add bb_openapi_validate_no_dangling_refs(), a generic cJSON oracle that
  walks a parsed document for any $ref with no matching components/schemas
  entry -- stronger and more reusable than a per-test string check; depth-
  bounded (mirrors BB_JSON_OBJ_MAX_DEPTH's "explicit cap" idiom, reusing
  this file's own PATH_DEPTH_MAX) so it fails closed rather than recursing
  unbounded now that it's a general-purpose reusable check
- strengthen the PR #1080 union-seam tests to assert the schema body (not
  just the $ref string) appears in components/schemas, and add dedup +
  ex... (continued)

7750 of 8355 branches covered (92.76%)

Branch coverage included in aggregate %.

85 of 85 new or added lines in 3 files covered. (100.0%)

13230 of 13388 relevant lines covered (98.82%)

2576.83 hits per line