dunglas / mercure / 30168905388

88%

master: 93%

Build Type

Pull #1322

github

Committed by Kévin Dunglas

Commit Message

fix: don't sort the update's own topic slice while dispatching

encode sorted the slice it was handed, and MatchAny hands it
Update.topics(). Under the deprecated_topic tag that returns the update's
own backing array when only the alternate topics are set, so dispatching
reordered them in place. MarshalJSON, LogValue and SpanAttributes all read
topics() and would then report the new order, persisted history included,
and the sort raced with any concurrent reader of the same update.

Sort the escaped copies instead. The key only has to be one canonical
string per topic set, which that gives just as well.

Pull Request Pull Request #1322: fix: don't sort the update's own topic slice while dispatching

Coverage Stats

2 of 0 new or added lines in 0 files covered. (NaN%)

2540 of 2878 relevant lines covered (88.26%)

112.52 hits per line