dunglas / mercure / 30168613872

88%

master: 93%

Build Type

Pull #1319

github

Committed by Kévin Dunglas

Commit Message

fix: don't close a connection whose write deadline is near

disconnectionTime is the write deadline minus dispatchTimeout, and the
timer is armed with time.Until on it, so a value in the past fires on the
first select iteration and the connection closes right after the headers.

Two configurations reach it. A token expiring within dispatchTimeout (5s by
default) is accepted by authorize and then dropped instantly, so the
subscriber reconnects in a loop until the token really expires; short-lived
tokens are recommended, which makes this the normal case near the end of a
token's life. A dispatchTimeout larger than writeTimeout does the same to
every connection.

Keep the margin when it is available and fall back to the write deadline
itself otherwise, so the subscriber gets the time its token grants. A zero
deadline still means no deadline, and no timer is armed.

Pull Request Pull Request #1319: fix: don't close a connection whose write deadline is near

Coverage Stats

14 of 0 new or added lines in 0 files covered. (NaN%)

29 existing lines in 1 file now uncovered.

2554 of 2890 relevant lines covered (88.37%)

110.8 hits per line