valkyrjaio / sindri-java / 30151289255

100%

push

github

[Http][Cli] Rename route terminated/exited middleware to responseSent/processExiting (#41)

# Description

Follows the framework's terminal middleware settlement-stage rename (see
the
valkyrja-java PR) through Sindri's AST route-attribute/middleware
readers, so the
generated route data keeps parity with the framework's renamed
middleware
stages. **Pure identifier rename, no behavior change**, scoped to HTTP
and CLI:

- **HTTP:** `terminatedMiddleware` → `responseSentMiddleware`, and
reader hook
  `updateTerminatedMiddleware()` → `updateResponseSentMiddleware()`.
- **CLI:** `exitedMiddleware` → `processExitingMiddleware`.

Verified locally against the updated framework (`-PlocalFramework`
composite →
`io.valkyrja:valkyrja -> project :valkyrja`) and against the published
framework:
`./gradlew spotlessApply` + full `ci` gate green (spotless, archunit,
errorprone,
spotbugs, junit; JaCoCo line + branch 100%).

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`ast/data/HttpRouteData` (+ contract)** — `terminatedMiddleware` →
  `responseSentMiddleware`.
- **`ast/HttpRouteMiddlewareReader` (+ contract)** — reader hook
  `updateTerminatedMiddleware()` → `updateResponseSentMiddleware()`.
- **`ast/data/CliRouteData` (+ contract)** — `exitedMiddleware` →
  `processExitingMiddleware`.
- **`.github/ci/junit/**`** — `HttpRouteMiddlewareReaderTest` updated
for the
  renamed reader hook.

## Sibling PRs

- valkyrja-java: https://github.com/valkyrjaio/valkyrja-java/pull/40

403 of 403 branches covered (100.0%)

Branch coverage included in aggregate %.

1213 of 1213 relevant lines covered (100.0%)

4.31 hits per line