valkyrjaio / sindri-php / 30149559649
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 79
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30149559649

push

github

web-flow 
[Http][Cli] Align terminal middleware stage naming (Terminated→ResponseSent, Exited→ProcessExiting) (#158)

# Description

Follows the terminal middleware stage rename in the framework
(**valkyrjaio/valkyrja-php#910**). Sindri's AST readers detect the
framework's middleware contracts and emit the corresponding named
arguments into generated route data, so the reader imports, local
variable names, and the named-argument string literals must track the
new stage names:

- **HTTP** — `TerminatedMiddlewareContract` →
`ResponseSentMiddlewareContract`; the `'terminatedMiddleware'` named arg
→ `'responseSentMiddleware'`.
- **CLI** — `ExitedMiddlewareContract` →
`ProcessExitingMiddlewareContract`; the `'exitedMiddleware'` named arg →
`'processExitingMiddleware'`.

This is a **pure identifier rename — no behavior or logic changes**.
Work is split into two commits, one per module: `[Http]` then `[Cli]`.

**Depends on valkyrjaio/valkyrja-php#910.** Sindri vendors
`valkyrja/valkyrja`; CI here will stay red until a Valkyrja release
carrying that rename is published, after which the version constraint
bump lands.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

**HTTP (`[Http]`)**

- **`Ast/HttpRouteMiddlewareReader`** — import
`ResponseSentMiddlewareContract`;
`classifyMiddleware()`/`updateMiddleware()` local var
`$responseSentMiddleware`; `buildNamedArg('responseSentMiddleware', …)`;
`is_a(…, ResponseSentMiddlewareContract::class)`.
- **`Ast/HttpRouteAttributeReader`** — `extractClassListArg($args,
'responseSentMiddleware', …)`; `responseSentMiddleware:` named arg.
- **`Ast/Contract/HttpRouteMiddlewareReader... (continued)

1546 of 1546 relevant lines covered (100.0%)

17.25 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30149559649.1 79
100.0
 GitHub Action Run
Source Files on build 30149559649