valkyrjaio / sindri-ts / 30148559471

100%

push

github

[Http][Cli] Rename terminal middleware stages Terminated→ResponseSent and Exited→ProcessExiting (#58)

# Description

Follows the valkyrja terminal middleware stage rename in Sindri's AST
readers:
the interface names Sindri matches when classifying route middleware
must track
valkyrja's renamed contracts.

Pure identifier rename with **no behavior change**:

- **HTTP** — `Terminated` → `ResponseSent` (the
`classImplementsInterface(…,
'TerminatedMiddlewareContract')` check →
`'ResponseSentMiddlewareContract'`,
plus the `terminatedMiddleware` field/params/locals that thread through
the
  reader, its contract, and `HttpRouteData`).
- **CLI** — `Exited` → `ProcessExiting` (the
`'ExitedMiddlewareContract'` check →
`'ProcessExitingMiddlewareContract'`, plus the `exitedMiddleware` slot
in the
  reader and `CliRouteData`).

Generated Route construction is positional, so the emitted output is
unchanged;
only the interface-name strings Sindri matches against needed updating
(and the
test fixtures that implement those interfaces).

**Depends on** valkyrjaio/valkyrja-ts#78 — Sindri matches valkyrja's
renamed middleware contracts by name, so this should land together with
/ after
that rename. Breaking change, targets `26.x`.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`Ast/HttpRouteMiddlewareReader.ts`** — interface check
`'TerminatedMiddlewareContract'` → `'ResponseSentMiddlewareContract'`;
`terminatedMiddleware` params/locals/`data.` access → `responseSent*`.
- **`Ast/HttpRouteAttributeReader.ts`**,
**`Ast/Contract/HttpRouteMiddlewareReaderContract.ts`** — matching
param/field renames.
- **`Ast/Da... (continued)

697 of 697 branches covered (100.0%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 4 files covered. (100.0%)

1130 of 1130 relevant lines covered (100.0%)

10.93 hits per line