valkyrjaio / valkyrja-ts / 30148037809

100%

push

github

[Http][Cli] Rename terminal middleware stages Terminated→ResponseSent and Exited→ProcessExiting (#78)

# Description

Aligns the two terminal middleware stages with the framework's dominant
Object+PastParticiple stage-naming convention, and makes each middleware
method
name match its stage type so one class can implement multiple middleware
stages
without method-name collisions (see `architecture/QUEUE.md` and the
"Middleware
settlement-stage naming" section of `architecture/TODO.md`).

This is a pure identifier/file rename with **no behavior change**:

- **HTTP** — stage 7 `Terminated` → `ResponseSent` (type, method
`terminated()`
→ `responseSent()`, and the `terminatedMiddleware` slot →
`responseSentMiddleware`).
- **CLI** — the terminal stage `Exited` → `ProcessExiting` (type, method
  `exited()` → `processExiting()`, and the `exitedMiddleware` slot →
`processExitingMiddleware`). CLI has no post-exit stage;
`ProcessExiting` is
  the stage-6 equivalent.

The middleware service-id constants were renamed **and their string
values
updated** (e.g.
`Valkyrja.Http.Middleware.Handler.TerminatedHandlerContract` →
`…ResponseSentHandlerContract`).

Breaking change, so this targets `26.x` (where the full test suite
lives).

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`Http/Middleware/Contract/TerminatedMiddlewareContract.ts`** →
**`ResponseSentMiddlewareContract.ts`** — renamed type +
`responseSent()` method.
-
**`Http/Middleware/Handler/{TerminatedHandler,Contract/TerminatedHandlerContract}.ts`**
→ **`ResponseSent*`** — renamed handler, its contract, and the
`HandlerContract` union member.
- **`... (continued)

1578 of 1578 branches covered (100.0%)

Branch coverage included in aggregate %.

27 of 27 new or added lines in 15 files covered. (100.0%)

3405 of 3405 relevant lines covered (100.0%)

20.06 hits per line