umputun / revdiff / 30147722426
90%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 76
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 89.928% (+0.01%) from 89.915%
30147722426

push

github

web-flow 
fix(ui): terminate page-down walk on an annotated last line (#288)

page-down hangs the TUI permanently when the last navigable line of a file carries an annotation. Found while reviewing #287, but it predates it: reproduced on both the pre-#287 base and current master.

`moveDiffCursorDownWithHunks` cleared `cursorOnAnnotation` before checking whether a next navigable line exists. With none left it reported a state change without moving, so `moveDiffCursorDownBy`'s "no more movement" guard, which compares only against the immediately previous step, never fired. The visual delta oscillates between the same two values, so the rows budget does not break the cycle either.

the flag now clears only once a next line is actually found. That also fixes `j` on the last line's annotation moving the cursor visually backward onto its diff row.

the freeze is worth knowing about because it is unrecoverable: bubbletea is wedged inside `Update`, so `shutdownGuard`'s `p.Quit()` blocks forever on the unbuffered `msgs` channel, and `signal.Notify` has already taken over SIGHUP/SIGTERM/SIGINT. `kill -TERM` does nothing. Only `kill -QUIT` or `kill -9` end it, and neither runs `finalize`. `.claude/rules/gotchas.md` records the invariant and that recovery path.

8 regression cases cover page-down and half-page-down, parked on the last line and walking into it, with and without a trailing divider. All 8 hang on the parent commit and pass with the fix.

11045 of 12282 relevant lines covered (89.93%)

2810.58 hits per line

Coverage Regressions

Lines Coverage ∆ File
22
96.28
 0.21% app/ui/diffnav.go
Jobs
ID Job ID Ran Files Coverage
1 30147722426.1 76
89.93
 GitHub Action Run
Source Files on build 30147722426