source-academy / frontend / 30145747182

43%

push

github

Bump conductor to 0.8.0 and await plugin loading in BrowserHostPlugin (#4171)

PR source-academy/conductor#53 makes hostLoadPlugin/requestLoadPlugin
async (Promise<void> instead of void) so the host can be waited on
before the runner proceeds, and renames the RPC procedure from the
notification $requestLoadPlugin to the awaitable requestLoadPlugin.

BrowserHostPlugin.requestLoadPlugin is the actual IHostPlugin
implementation and now matches the new abstract Promise<void>
signature, threading the async contract through createConductor's
onRequestLoadPlugin param down to conductorEvaluatorCache.ts, which
previously fired loadWebPlugin() (an already-async URL-resolve +
import()) with `void ...` to work around the old sync signature. This
is the actual point of conductor#53: large tab bundles (plotly etc.)
now block the runner via hostLoadPlugin's await instead of racing it.

2787 of 7580 branches covered (36.77%)

Branch coverage included in aggregate %.

0 of 2 new or added lines in 2 files covered. (0.0%)

6504 of 14236 relevant lines covered (45.69%)

28.62 hits per line