kevinoid / NLCaseConvert / 30115338529

89%

push

github

feat: add configurable Regex match timeout

Microsoft recommends that developers [use time-out values] with `Regex`
to avoid denial-of-service attacks.  This is checked by analyzer S6444
of `SonarAnalyzer.CSharp` (added by
<https://github.com/SonarSource/sonar-dotnet/pull/5693>).

Add a `MatchTimeout` property to each `Builder` with a reasonable (if
somewhat arbitrarily chosen) default and pass the configured value to
the `Regex` constructor to apply it.

[use time-out values]: https://learn.microsoft.com/en-us/dotnet/standard/base-types/best-practices-regex#use-time-out-values

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>

12 of 12 new or added lines in 3 files covered. (100.0%)

481 of 543 relevant lines covered (88.58%)

4.43 hits per line