carapace-sh / carapace / 30114450443

61%

push

github

argumentstyle (#1227)

* pflagfork: handle Flag.ArgumentStyle to control accepted argument variants

Add ArgumentStyle() method and helper functions (acceptsNext, acceptsDelimited,
acceptsAttached) to check which argument styles a flag accepts. Update lookup
functions to respect these constraints when parsing flag arguments.

Also rename Mode() to GetMode() to avoid conflict with embedded pflag.Flag.Mode field.

Assisted-by: Crush:minimax-m2.7

* tmp

* example-nonposix: add argumentstyle subcommand and tests

Add subcommand to test each ArgumentStyle configuration:
- AcceptNext (1), AcceptDelimited (2), AcceptAttached (4)
- Combined styles like AcceptDelimited|AcceptNext
- Shorthand variants for each

Includes unit tests for pflag parsing behavior.

Assisted-by: Crush:minimax-m2.7

* fix test

* added test

* fix: handle ArgumentStyle restrictions for shorthand flags

- Export AcceptsNext/AcceptsDelimited/AcceptsAttached methods in pflagfork/flag.go
- Update flagset.go to use exported method names
- In traverse.go: don't complete attached argument when flag doesn't accept attached style
- In traverse.go: avoid ParseFlags error when shorthand lookup fails due to style restrictions
- Update argumentstyle_test.go nospace expectations to match actual behavior

Assisted-by: Crush:minimax-m2.7

* fix: gate flag-argument completion on AcceptsNext and clean up code

- Fix failing TestAcceptAttached: traverse.go now checks AcceptsNext()
  before completing a flag argument in the next-arg position, so flags
  with AcceptAttached-only style no longer incorrectly offer value
  completions when the user types `-3 <TAB>`.
- Replace magic numbers in internalActions.go with named pflagfork
  constants (NameAsShorthand, Default) via GetMode().
- Revert go.mod/example-nonposix go.mod local replace directives back
  to versioned carapace-pflag; keep local override in go.work only.
- Add named constants for ArgumentStyle bitmask values in pflagfork.
- Simplify lookupPos... (continued)

93 of 105 new or added lines in 6 files covered. (88.57%)

3905 of 6379 relevant lines covered (61.22%)

1.03 hits per line