keplergl / kepler.gl / 30109144418

54%

push

github

[Bug] Preserve custom basemap style attributions (#3515) (#3543)

Custom basemap styles (e.g. OpenFreeMap, OpenMapTiles) declare their own
attribution in the source TileJSON, but kepler.gl only recognized a
hardcoded OpenStreetMap case and collapsed detection to a boolean, so the
custom attributions were dropped from the rendered map.

- add getBaseMapAttributions() to collect the real attribution strings
  from the resolved map sources (de-duplicated), instead of the OSM-only
  boolean check
- track basemapAttributions in map-container and pass them to Attribution
- render collected attributions as safe React links (parses only anchors
  with http(s)/mailto hrefs, everything else becomes text; no
  dangerouslySetInnerHTML), falling back to the generic OSM link only when
  nothing was collected to avoid double-rendering
- add unit tests for getBaseMapAttributions

Note: the secondary report in #3515 (an unnecessary CARTO style.json
request in exported HTML) is a separate networking concern and is not
addressed here.

Signed-off-by: Hafiz Hussain <huxain69@gmail.com>

7848 of 17365 branches covered (45.19%)

Branch coverage included in aggregate %.

17 of 44 new or added lines in 2 files covered. (38.64%)

15806 of 26184 relevant lines covered (60.37%)

71.82 hits per line