tarantool / tarantool / 30085114546

88%

Build Type

push

github

Committed by locker

Commit Message

box: refactor read view activation internal API

The read view core implementation is MT-safe: it's okay to access the
same read view concurrently from multiple threads. However, to implement
a box-like API with support for tuple field names and space upgrade, we
need space formats, which are thread-local. Currently, we attach the
formats to a read view with the so called "activation" procedure, see
read_view_activate. It creates all required formats and stores them
right in the read view core object. The problem here is that this API
isn't suitable for using the same read view object in multiple threads -
it may only be used for passing a read view from one thread to another.

Let's replace the "activation" procedure with creation of a "handle".
A handle contains a pointer to a core read view object plus info
required to implement a box-like API (space formats, upgrade state).
Note, handle structures exist only for database and space read view
objects. There's no handle for an index object because we don't need
to attach any thread-local data to it.

This commit refactors our internal read view API and patches the Lua
module, which is the only place where it's used. This is a preparation
for making read views available in application threads.

Needed for #12951

NO_DOC=refactoring
NO_TEST=refactoring
NO_CHANGELOG=refactoring

Coverage Stats

72054 of 120914 branches covered (59.59%)

105 of 118 new or added lines in 3 files covered. (88.98%)

48 existing lines in 10 files now uncovered.

108023 of 123002 relevant lines covered (87.82%)

1391599.07 hits per line