kubernetes-sigs / lws / 30084924538

59%

main: 58%

Build Type

Pull #922

github

Committed by hasB4K

Commit Message

docs(kep-849): describe the External+replicas>1 admission warning correctly

The Risks and Mitigations section claimed a per-role CEL rule forbidding
spec.replicas > 0 when scaling.mode == External. That rule was never
implemented and is not implementable as-is: LeaderWorkerSetSpec.Replicas
carries +kubebuilder:default=1, and API-server defaulting runs before
CEL, so every External role would arrive at CEL validation with
spec.replicas == 1 and be rejected. The impl uses a webhook admission
warning (not a rejection) when an explicit value > 1 is set. Rewrite
the paragraph to describe the actual behavior and the defaulting reason
that forced the choice.

Pull Request Pull Request #922: feat(disaggregatedset): per-role autoscaling via DisaggregatedSetRoleScaler

Coverage Stats

182 of 236 new or added lines in 4 files covered. (77.12%)

34 existing lines in 1 file now uncovered.

2502 of 4281 relevant lines covered (58.44%)

45.56 hits per line