supabase / supabase-swift / 30082951985

84%

Build Type

push

github

Committed by web-flow

Commit Message

test: migrate RealtimeTests to Swift Testing (Phase 7) (#1141)

* test: migrate RealtimeTests to Swift Testing (Phase 7)

Converts every XCTest suite in Tests/RealtimeTests to Swift Testing
(@Suite/@Test, #expect/#require, Issue.record), per SDK-435 phase 7
(SDK-1254).

- Replaces XCTestExpectation/fulfillment(of:timeout:) with a shared
  `waitUntil` polling helper (Tests/RealtimeTests/TestSupport.swift),
  since Swift Testing has no direct async-condition-with-timeout
  primitive.
- Preserves `withMainSerialExecutor` usage in RealtimeTests.swift,
  now applied per-test-body with `@Suite(.serialized)` to keep the
  process-global executor flag from racing across concurrently
  running tests.
- Converts XCTestCase setUp/tearDown to struct/class init()/deinit,
  keeping class-based suites (with explicit `sut.disconnect()` in
  deinit) where teardown must run background-task cancellation, not
  just ARC release.
- Serializes WebSocketTests (`@Suite(.serialized)`): its cert-pinning
  tests import self-signed identities via SecPKCS12Import, which is
  flaky when several tests run concurrently (Swift Testing's default
  parallel execution, vs. XCTest's serial method execution).
- Converts completion-handler-based challenge-forwarding tests to
  `confirmation(_:)`.
- Adds "RealtimeTests" to Package.swift's swift6TestTargets now that
  the target is fully migrated.

Behavior, coverage, and assertions are unchanged; only the test
framework and incidental concurrency helpers differ.

* fix: address CI failures in RealtimeTests Swift Testing migration

- WebSocketTests: mark local delegate test doubles @unchecked Sendable
  to satisfy Sendable-conforming URLSessionDelegate/URLSessionTaskDelegate
  under strict concurrency (compile error on all xcodebuild jobs)
- ConnectionManagerTests: replace fixed 50ms sleep with waitUntil poll
  to avoid a race under parallel Swift Testing execution (flaky on Linux CI)
- dictionary: add 'deinits' for cspell

* fix(test): addr... (continued)

Coverage Stats

4 of 18 new or added lines in 1 file covered. (22.22%)

3 existing lines in 1 file now uncovered.

8185 of 9785 relevant lines covered (83.65%)

39.08 hits per line