FlexMeasures / flexmeasures / 30077606381

83%

Build Type

push

github

Committed by web-flow

Commit Message

Fix reading (boolean) settings from the environment, incl. SECURITY_TWO_FACTOR (#2341)

* fix: read SECURITY_TWO_FACTOR from the environment, as documented

The installation docs (and now the configuration docs, via PR #2340)
advise enabling 2FA with 'export SECURITY_TWO_FACTOR=True', but
read_env_vars never read that variable, so the app silently stayed
on the default (False). Parse it explicitly as a boolean, since env
values arrive as strings.

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* docs: changelog entry for SECURITY_TWO_FACTOR env var fix

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* fix: parse boolean settings from the environment properly

Environment values are strings, so any non-empty value - including
'False' or '0' - counted as enabled for DEBUG, and reached consumers
raw for MAIL_USE_TLS, MAIL_USE_SSL and FLEXMEASURES_JSON_COMPACT.
Coerce env values to booleans whenever the setting's default is a
boolean, and drop the now-redundant string special-casing for
FLEXMEASURES_JSON_COMPACT in app.py.

Signed-off-by: F.N. Claessen <claessen@seita.nl>

* fix: address review — docstring+strip for parse_bool_env, read SENTRY_DSN (keep SENTRY_SDN fallback), strict bool for json compactness; add tests

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rjb8po3m8vyEvm7CnYVtwd

* fix: key boolean env coercion off DefaultConfig, broaden tests, clarify SENTRY_SDN is env-only

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rjb8po3m8vyEvm7CnYVtwd

---------

Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Coverage Stats

11 of 11 new or added lines in 2 files covered. (100.0%)

47 existing lines in 4 files now uncovered.

15847 of 19126 relevant lines covered (82.86%)

0.83 hits per line