openconfig / featureprofiles / 30069936959

9%

Build Type

push

github

Committed by web-flow

Commit Message

Hardening gNSI credentialz helpers and SSH auth tests for spec-compliant rotations, deterministic versioning, and vendor-safe cleanup/validation (#5639)

* Hardening gNSI credentialz helpers and SSH auth tests for spec-compliant rotations, deterministic versioning, and vendor-safe cleanup/validation

* Address gemini-code-assist review feedback

- credz.go: nil-safe RotateUserPassword/RotateAuthorizedPrincipal (single request build)
- credz.go: function-local charClasses to avoid rand.Shuffle data race
- credz.go: runRotate uses timed t.Context() with background fallback on cleanup path
- host_certificates_test.go: deterministic host cert versions via -1/-2 suffixes (no time.Sleep)

Signed-off-by: asishkbasu <asish@juniper.net>

* Addressing gemini-code-assist review feedback

Signed-off-by: asishkbasu <asish@juniper.net>

* Address Gemini review: close SSH client in host_certificates; fix CommandResult handling in ssh_password_login_disallowed

---------

Signed-off-by: asishkbasu <asish@juniper.net>
Co-authored-by: Ram <rmachat@google.com>

Coverage Stats

0 of 93 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

2305 of 27075 relevant lines covered (8.51%)

0.1 hits per line