30055979440
73%

Ran 24 Jul 2026 03:23AM UTC

Jobs 1

Files 2165

Run time 3min

Badge

Embed ▾

Committed 23 Jul 2026 05:57PM UTC coverage: 73.111% (+0.04%) from 73.067%

Build # 30055979440

Build Type

push

github

Committed by

yuwata

Commit Message

user-record: validate JSON shell fields with valid_shell()

The user record loader currently uses a generic filename-or-path check
for shell and fallbackShell. This allows values that homectl rejects,
including relative names, control characters, colons, and trailing
slashes.

Use valid_shell() for all three record locations and cover the top-level,
matching per-machine, and status fallback fields at the loader boundary.

Fixes #43066

Coverage Stats

35 of 36 new or added lines in 2 files covered. (97.22%)

514 existing lines in 41 files now uncovered.

346901 of 474487 relevant lines covered (73.11%)

1323376.8 hits per line

Uncovered Changes

Lines	Coverage	∆	File
1	98.44	-1.56%	src/test/test-user-record.c

Coverage Regressions

Lines	Coverage	∆	File
132	41.4	-0.07%	src/shared/ask-password-api.c
119	61.06	-14.71%	src/bootctl/bootctl-link.c
59	81.68	-0.27%	src/core/timer.c
57	84.16	-0.03%	src/network/networkd-link.c
19	95.45	0.2%	src/basic/strv.c
13	62.89	-0.27%	src/machine/machined-resolve-hook.c
12	80.97	-0.54%	src/libsystemd/sd-varlink/sd-varlink.c
11	68.21	-2.99%	src/core/scope.c
9	84.94	-0.91%	src/udev/udev-manager.c
8	72.87	27.13%	src/bootctl/bootctl-install.c
8	58.45	-1.35%	src/timesync/timesyncd-manager.c
7	96.88	1.29%	src/basic/utf8.c
5	85.41	-1.2%	src/network/networkd-sysctl.c
4	40.29	-0.19%	src/login/logind-dbus.c
4	88.46	-1.18%	src/shared/serialize.c
3	75.0	-2.68%	src/coredump/coredump-vacuum.c
3	56.24	-0.35%	src/login/logind-session.c
3	81.99	-1.15%	src/shared/journal-importer.c
3	65.93	-0.95%	src/udev/udev-format.c
2	69.95	0.0%	src/core/exec-invoke.c
2	80.28	-0.12%	src/core/execute.c
2	82.31	-0.1%	src/core/namespace.c
2	90.13	-0.52%	src/journal/journald-context.c
2	77.17	0.0%	src/journal/journald-manager.c
2	77.36	-0.09%	src/libsystemd/sd-bus/sd-bus.c
2	86.36	-0.05%	src/libsystemd/sd-journal/sd-journal.c
2	79.07	-0.06%	src/resolve/resolved-dns-transaction.c
2	84.08	0.73%	src/resolve/resolved-link.c
2	44.17	-0.54%	src/resolve/resolved-mdns.c
2	75.0	-25.0%	src/shared/find-esp.h
2	95.83	2.5%	src/shared/plymouth-util.c
2	83.33	-3.7%	src/udev/udev-builtin-net_setup_link.c
1	46.82	-0.07%	src/basic/terminal-util.c
1	75.98	-0.16%	src/core/transaction.c
1	55.56	-0.09%	src/home/homed-manager.c
1	95.38	-0.38%	src/libsystemd-network/sd-dhcp-server-lease.c
1	68.43	-0.14%	src/login/logind.c
1	32.73	-0.23%	src/login/logind-varlink.c
1	66.46	-0.08%	src/nsresourced/nsresourcework.c
1	70.56	-0.16%	src/systemctl/systemctl-list-units.c
1	93.91	-0.1%	src/test/test-time-util.c

Jobs

ID	Job ID	Ran	Files	Coverage
1	30055979440.1	24 Jul 2026 03:23AM UTC	2165	73.11	GitHub Action Run

systemd / systemd / 30055979440
73%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Changes

Coverage Regressions

Jobs

Source Files on build 30055979440

systemd / systemd / 30055979440 73%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Changes

Coverage Regressions

Jobs

Source Files on build 30055979440

systemd / systemd / 30055979440
73%

README BADGES
x