stacklok / toolhive / 30004792349

69%

Build Type

push

github

Committed by web-flow

Commit Message

Add project-level skills lock file schema package (#5892)

* Add project-level skills lock file schema package

RFC THV-0080 pins every project-scoped skill install to a
committed toolhive.lock.yaml so teams get reproducible installs
across machines, the same guarantee package-lock.json/Cargo.lock
provide elsewhere. This package defines the v1 schema (entries,
content digest, requiredBy) with no callers yet; skillsvc wiring
follows in a later PR of the stack.

Access is confined to the validated project root via os.Root
(OS-enforced containment), not string validation alone.

* Fix content-digest path forgery and unvalidated lock writes

Path validation rejected traversal but not control characters, so a
crafted Path containing an embedded NUL and newline could reproduce
the byte stream of an unrelated multi-file tree and collide with its
digest. Save also never validated before writing, so a caller bug
could persist an invalid lock file with no recovery through the
package API. Also normalize repeated "./" prefixes idempotently.

* Harden lock file schema against skew, forgery, and races

Address panel-review findings on the schema package: unknown fields
written by a newer binary were silently stripped on the next Save
(breaking the deferred Sigstore fields before they exist) — round-trip
them via inline maps; resolvedReference was completely unvalidated
despite being the exact value sync fetches from without re-resolving —
constrain it syntactically (strict OCI or git:// parse, no control
characters, bounded length); Save used a fixed temp filename with no
lock, so two direct concurrent calls could promote or destroy each
other's half-written file — use a per-call random suffix; and a
hand-edited requiredBy ring of non-explicit entries validated cleanly
yet could never be cascade-removed — reject cycles at validation.
Also document the frozen digest algorithm's file-mode/symlink
limitations.

Coverage Stats

291 of 331 new or added lines in 3 files covered. (87.92%)

14 existing lines in 5 files now uncovered.

77172 of 111543 relevant lines covered (69.19%)

75.09 hits per line