kubevirt / hyperconverged-cluster-operator / 29998599943

85%

push

github

Deprecate persistent reservation feature gate in follow up to upstream GA/toggle (#4389)

* Deprecate persistentReservation FG in favor of storage.persistentReservationConfiguration.enabled

The PersistentReservation feature gate has graduated in KubeVirt to a
dedicated configuration field. Add a new
spec.storage.persistentReservationConfiguration.enabled field in the v1
API and mark the old persistentReservation feature gate as deprecated.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>

* Add v1 <=> v1beta1 conversion for persistentReservationConfiguration

Add conversion logic to map the deprecated v1beta1 persistentReservation
feature gate to v1 spec.storage.persistentReservationConfiguration.enabled
and vice versa. Store both field and FG state in the v1-only-fields
annotation for round-trip fidelity through v1beta1.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>

* Use PersistentReservationConfiguration in KubeVirt handler instead of FG string

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>

* Sync persistentReservation FG with persistentReservationConfiguration.enabled in v1 mutator

Same-direction semantics: FG enabled = field enabled. Handles
create/update with the full 81-case matrix, including contradiction
rejection, FG auto-removal, and field auto-sync.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>

* Warn on deprecated persistentReservation FG in v1beta1 validator

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>

* Document persistentReservationConfiguration.enabled and deprecate FG in docs

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>

---------

Signed-off-by: Alex Kalenyuk <aka... (continued)

176 of 176 new or added lines in 4 files covered. (100.0%)

11701 of 13719 relevant lines covered (85.29%)

2.25 hits per line