source-academy / py-slang / 29997037239

86%

push

github

Remove dead RunOptions.envSteps parameter (#326)

Closes #274. envSteps was threaded from RunOptions all the way down to
generateCSEMachineStateStream, but its only use site was commented out —
the parameter (underscore-prefixed there, _envSteps) did nothing at the
interpreter level. runCode() called with default options had no real step
protection at all: stepLimit defaults to -1 (unlimited) and envSteps
(default 100000) was a no-op, so a genuine infinite loop would hang
forever unless a caller explicitly passed stepLimit.

Removed rather than re-enabled: generateCSEMachineStateStream's while loop
already yields unconditionally on every single step (the commented-out
envSteps check was meant to yield-and-return early, pausing execution
after N steps) — but nothing needs that anymore. PyCseMachinePlugin.ts's
collectSnapshots, the actual live consumer backing the CSE-machine
visualizer (not just runner.ts's headless path), already does its own
truncation via maxSnapshots (`if (snapshots.length >= maxSnapshots)
break`), consuming the full unconditional-yield stream and stopping itself
whenever it has enough. Whatever pagination need envSteps was originally
for is already solved a different way, at the consumer rather than the
producer — re-enabling the dead check would have been redundant with
logic that already works, not a fix for a real gap.

Removed the same dead parameter from every layer it was threaded through:
RunOptions (runner.ts), IOptions (engines/cse/interpreter.ts, a second,
separate options-threading layer for evaluate()/runCSEMachine — not just
runner.ts's own copy), collectSnapshots (PyCseMachinePlugin.ts, plus its
two hardcoded-100000 call sites in PyCseEvaluator.ts), and an orphaned
envSteps: -1 field in context.ts's createEmptyRuntime() that was never
even part of Context.runtime's declared type, read nowhere.


Claude-Session: https://claude.ai/code/session_01KrwJGug3rCXijRseRjys9V

Co-authored-by: Claude Sonnet 5 <noreply@anthropic... (continued)

4393 of 5490 branches covered (80.02%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

9510 of 10652 relevant lines covered (89.28%)

178710.92 hits per line