openego / eDisGo / 29927928854

83%

dev: 84%

Build Type

Pull #629

github

Committed by web-flow

Commit Message

fix: preserve gaps in the timeindex when resampling (#721)

The shared tools.resample() function called pandas' own .resample()
directly on each attribute's data, which always produces a contiguous
bucket sequence spanning the data's own min-to-max timestamp - any gap in
a legitimately gapped timeindex (e.g. as produced by select_timesteps in
auto mode, which deliberately keeps two disjoint intervals separate) got
silently filled with resample artifacts (forward-filled/averaged copies
of adjacent real values) rather than preserved.

TimeSeries.resample compounded this: after calling the shared function,
it also rebuilt self._timeindex via one pd.date_range(first, last, freq)
span, discarding the gap from the index itself, not just the data.

Add split_into_contiguous_runs, splitting a DataFrame into its maximal
contiguous runs (a run boundary is any gap larger than the original
frequency). The shared resample() function now resamples each run
independently and concatenates the results, so a gap is never bridged.
TimeSeries.resample's own _timeindex rebuild now reconstructs the new
index per contiguous run and unions them back together, fixing the
compounding issue on top.

Affects every caller of the shared function: TimeSeries.resample,
HeatPump.resample_timeseries, DSM.resample, OverlyingGrid.resample.
Electromobility.resample is unaffected - it already warns on
non-continuous input rather than silently fabricating data.

Found during the #703 PR series (time-series writers not uniformly
respecting a pre-existing timeindex), tracked separately since it's a
distinct pre-existing bug in shared infrastructure, not part of #703's
own scope.

Pull Request Pull Request #629: Edisgo run edisgo

Coverage Stats

803 of 1080 new or added lines in 29 files covered. (74.35%)

2 existing lines in 2 files now uncovered.

9527 of 11443 relevant lines covered (83.26%)

0.83 hits per line