raystack / frontier / 29993203189

47%

main: 47%

Build Type

Pull #1795

github

Committed by rohilsurana

Commit Message

fix(reconcile): match and export platform-user emails by address

The server can store a user's email as a display-name form ("Alice <a@x.com>"), so exporting the stored email verbatim produced a document the strict validation rejected, breaking the rule 5 round trip. Compare emails by their parsed address instead: validate accepts a uuid or any email, matching compares the lowercased address (so a display-name or differently-cased ref matches the stored address), and export emits the normalized address, or the id when the stored value is not an email. A uuid never parses as an email, so a uuid ref matches only by id and a user whose email is another user's id can neither be matched nor exported as that id. Closes the PlatformUser rule 5 gap over every reachable email form.

Uses mail.ParseAddress per review discussion; this does not fold plus-addressing (abc+1 and abc+2 stay distinct), only display name and case.

Pull Request Pull Request #1795: fix(reconcile): close the PlatformUser Rule 2 and Rule 5 gaps

Coverage Stats

28 of 28 new or added lines in 3 files covered. (100.0%)

1 existing line in 1 file now uncovered.

18156 of 38910 relevant lines covered (46.66%)

14.25 hits per line