raystack / frontier / 29988651525

46%

main: 47%

Pull #1794

github

fix(reconcile): validate a preference value only when it becomes a set

The first cut validated every listed value, which broke the export round trip (rule 5): a value stored under an older or looser trait definition is exported verbatim, and re-reconciling it was rejected even though it equals the server's own value and plans no op. Validate only a value that differs from the one in effect, so a planned set is still appliable but a no-op set is left alone. Also treat a stored empty value as unset in both the reset loop and export, so it is not reset and not exported as an empty value the plan would reject. Adds tests for the stale-value round trip, the stored-empty cases, and value validation over the wire (exercising the proto-to-core trait mapping, not just the text path).

58 of 73 new or added lines in 2 files covered. (79.45%)

17844 of 38589 relevant lines covered (46.24%)

14.1 hits per line