hyperledger / fabric-x-committer / 29983184272

91%

Build Type

push

github

Committed by web-flow

Commit Message

[config] Default value annotation (#669)

#### Type of change

- Improvement (improvement to code, performance, etc)
 
#### Description

- Declare config defaults with `default:"..."` struct tags, applied to
Viper by a single reflection walk (unified with the existing
env-override walk)
- Support struct-assignment tags (`key=value`) for scoped nested
defaults on shared types (retry, orderer suspicion window, logging spec)
- Move per-service default ports into `cmd/config`; remove all other
defaults-only constants from service packages
- Drop `required` from fields that carry a default
- Scope rate-limit and max-concurrent-streams defaults to the
client-facing services (query, sidecar)
- Align sample-YAML`# Default:` comments with the actual defaults

#### Related issues

- resolves #570

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

75 of 75 new or added lines in 3 files covered. (100.0%)

25 existing lines in 8 files now uncovered.

10283 of 11264 relevant lines covered (91.29%)

34183.55 hits per line