source-academy / py-slang / 29974161260

86%

push

github

PVML: fix print(print) showing "<built-in function display>" (#327)

Closes #278. cse-interop.ts's primitiveNameOf builds an index->name
reverse map from PRIMITIVE_FUNCTIONS (builtins.ts) to render a bare
primitive reference. Two indices have more than one registered name --
print/display both -> 5, len/list_length both -> 2 -- and the reverse map
was built via `new Map(array-of-pairs)`, which keeps the *last* entry for
a repeated key. Since display/list_length are listed after their
canonical name in PRIMITIVE_FUNCTIONS (each commented as the alias), the
alias silently won the reverse lookup for both shared indices, even though
the user only ever referenced the canonical name.

Fixed by keeping whichever name claims an index first instead of last.
Confirmed there's no real downside: the alias names (display, list_length)
aren't resolvable as bare name references at all on either engine --
`print(display)` raises NameNotFoundError on both CSE and PVML, matching
their being call-only builtins -- so there's no valid program where this
change makes a previously-correct display string wrong.


Claude-Session: https://claude.ai/code/session_01KrwJGug3rCXijRseRjys9V

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

4385 of 5460 branches covered (80.31%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

9450 of 10547 relevant lines covered (89.6%)

178797.13 hits per line