dangernoodle-io / breadboard / 29967503359

96%

push

github

refactor: dissolve bb_storage_http into bb_diag_http (B1-1154) (#1008)

- folds DELETE /api/diag/storage and POST /api/diag/factory-reset (already
  diag-namespaced) into bb_diag_http, per KB 1477: an SSOT component owns no
  routes, and its own HTTP surface is the sole route home
- removes the bb_storage_http component entirely (CMakeLists, Kconfig,
  README, both wire/route source files git-mv'd into bb_diag_http, keeping
  their file names)
- keeps the CONFIG_BB_STORAGE_HTTP_FACTORY_RESET Kconfig symbol unchanged so
  any sdkconfig.defaults already setting it still works
- merges bb_storage_http's REQUIRES/PRIV_REQUIRES (bb_storage, bb_settings,
  bb_timer) into bb_diag_http's CMakeLists, carrying over its host-scaffold
  hint for the portable routes file
- prunes the bb_storage_http entry from the new_component fence baseline
  (shrink-only)
- folds bbtool.toml's bb_storage_http capability entries into bb_diag_http
- smoke capability: swap bb_storage_http for bb_diag + bb_diag_http; bb_diag
  is listed explicitly to match this list's explicit-closure enumeration
  style (inert to codegen since bb_diag_http requires it transitively)
- sweeps stale bb_storage_http precedent comments across the codebase that
  referenced it as a standalone component identity (filename/function-name
  citations were left as-is since those didn't change)

7386 of 7976 branches covered (92.6%)

Branch coverage included in aggregate %.

12530 of 12692 relevant lines covered (98.72%)

2498.78 hits per line